Game API v4.0.0: Achievement support for RetroPlayer #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikosSiak
reviewed
Feb 6, 2023
| @@ -42,7 +43,13 @@ class CCheevos | |||
| const std::string& richPresence); | |||
| void EnableRichPresence(const std::string& script); | |||
| void EvaluateRichPresence(std::string& evaluation, unsigned int consoleID); | |||
| void ActivateAchievement(unsigned cheevo_id, const char* memaddr); | |||
There was a problem hiding this comment.
Change the param name to cheevoId to match the code style. This applies for the other methods as well
| @@ -51,6 +58,9 @@ class CCheevos | |||
| size_t Reduce(size_t addr, size_t mask); | |||
|
|
|||
| static unsigned int PeekInternal(unsigned address, unsigned num_bytes, void* ud); | |||
| static void RuntimeEventHandler(const rc_runtime_event_t* runtime_event); | |||
|
|
|||
| void (*m_callback)(const char* achievement_url, unsigned cheevo_id); | |||
There was a problem hiding this comment.
Not sure why but I remember that we wanted to remove this, I had open this PR Shardul555#1 I just rebased it on this PR.
@garbear can you check it if you remember why we wanted this
There was a problem hiding this comment.
We don't want a static function in RetroPlayer.
| void CCheevos::ActivateAchievement(unsigned cheevo_id, const char* memaddr) | ||
| { | ||
| rc_runtime_activate_achievement(&m_runtime, cheevo_id, memaddr, NULL, 0); | ||
| // it will return integer value 0 in case achivement is activated successfully. |
There was a problem hiding this comment.
maybe we should add a check here instead of a comment like we do in the other methods
|
I had to make the following change to update for upstream changes: diff --git a/src/client.cpp b/src/client.cpp
index 86376d1..f9ec5be 100644
--- a/src/client.cpp
+++ b/src/client.cpp
@@ -504,7 +504,8 @@ GAME_ERROR CGameLibRetro::RCGetPatchFileUrl(std::string& url,
return GAME_ERROR_NO_ERROR;
}
-GAME_ERROR CGameLibRetro::SetRetroAchievementsCredentials(const char* username, const char* token)
+GAME_ERROR CGameLibRetro::SetRetroAchievementsCredentials(const std::string& username,
+ const std::string& token)
{
CCheevos::Get().SetRetroAchievementsCredentials(username, token);
return GAME_ERROR_NO_ERROR;
diff --git a/src/client.h b/src/client.h
index d06e4b6..f2e84f4 100644
--- a/src/client.h
+++ b/src/client.h
@@ -78,7 +78,8 @@ public:
const std::string& username,
const std::string& token,
unsigned int gameID) override;
- GAME_ERROR SetRetroAchievementsCredentials(const char* username, const char* token);
+ GAME_ERROR SetRetroAchievementsCredentials(const std::string& username,
+ const std::string& token) override;
GAME_ERROR RCPostRichPresenceUrl(std::string& url,
std::string& postData,
const std::string& username, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement support for Achievements in ReteroPlayer. This PR is based on #67 , for adding support of RCheevos.
This PR is used by garbear/xbmc#126 for implementing Achievements.